Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --use-pnp for Yarn 2 #8460

Merged
merged 2 commits into from
May 5, 2020
Merged

Fix --use-pnp for Yarn 2 #8460

merged 2 commits into from
May 5, 2020

Conversation

nickserv
Copy link
Contributor

@nickserv nickserv commented Feb 11, 2020

The --use-pnp flag will break Yarn 2 because PnP has been enabled by default and the flag has been removed. This improves user experience by automatically ignoring the flag for Yarn 2, and explaining that it won't be needed in the future.

I've tested this with Yarn 1 and it works normally, though Yarn 2 has a different installation linking system that I couldn't get to work with create-react-app locally.

Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks @nickmccurdy. @ianschmitz can I get a second review on this one? Thanks!

@ianschmitz ianschmitz added this to the 3.5 milestone Apr 7, 2020
@kusmierz
Copy link

hi guys, as we have 2 reviews already, is it possible to merge it?

@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
@iansu iansu merged commit 1f81469 into facebook:master May 5, 2020
@iansu
Copy link
Contributor

iansu commented May 5, 2020

Thanks!

@lock lock bot locked and limited conversation to collaborators May 20, 2020
@nickserv nickserv deleted the use-pnp branch June 8, 2022 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants